[MERGE] Create a SearchResult for memoising graph searches

Robert Collins robertc at robertcollins.net
Thu Jan 17 22:29:35 GMT 2008


On Fri, 2008-01-18 at 08:44 +1100, Robert Collins wrote:
> On Thu, 2008-01-17 at 13:40 -0600, John Arbash Meinel wrote:


> > I don't think it is enough to make us want to spend the time
> > committing
> > revisions, though. So I'm happy enough to have it pulled out.
> > 
> > If we are going to get rid of it here, we should probably get rid of
> > the
> > "prepare_memory_tree" and "build_ancestry" helpers, since I don't
> > think
> > they are used anymore.
> 
> I agree; that patch has a small bug - it does not handle 'stop...' for
> null: in a full-branch pull of bzr, I think this is almost certainly a
> ghost related issue and I'm just whipping up a test for it. I'll delete
> those helpers at the same time.
> 
> If we want to enforce the DAG shape; the helper can do that (do a topo
> sort - that will find loops).

FWIW those helpers are still used.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080118/6036e97f/attachment.pgp 


More information about the bazaar mailing list