[MERGE] (#183391) improve PyPI integration by adding project metadata to setup.py

Martin Pool mbp at sourcefrog.net
Thu Jan 17 07:15:17 GMT 2008


> > As a followon, I see our version number format differs from that
> > specified in <http://docs.python.org/dist/meta-data.html>, which wants
> > e.g. '1.1pr1'.  We could change that.  I remember Alexander previously
> > said that 1.1.0.preview.1 was somehow easier for him to use though...
>
> BB:approve
>
> We went with 1.1.0.final.1 because it is easier to parse with a simple
> "version.split('.')".
>
> I believe python itself does 1.1.0final1 which is what we did for a while.

Of course for Python code they can get the components from
bzrlib.version_info, so I'm not totally sure why that parsing would be
needed.

>
> We could leave the value of "bzrlib.__version__" alone, and just use:
>
> version='%s.%s.%s%s%s' % bzrlib.version_info
>
> if you prefer.

Actually, Python now just says 2.5.1 in every place I can see.

> +    'long_description': file("README").read(),
>
> ^- This seems like a risky thing to do. Maybe we should at least split
> it out from inside the dict() into a helper function?

The setup.py also does just 'import bzrlib', which I thought would
also be risky.  But I guess (on all platforms?) the directory of the
script is put at the start of the path, so we get the right one.

I also added some assertions to catch one mistake I made in the release process.

Thanks.
-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080117-versioning.diff
Type: text/x-diff
Size: 15784 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080117/7c05bac7/attachment.bin 


More information about the bazaar mailing list