[MERGE] Fix error handling in insert_data_stream (+ remove duplicate HeadsCache)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lukáš Lalinský wrote:
> Here is a patch for two problems in Repository.insert_data_stream:
> 
>    - It always fails on already present revisions for pack and remote
> repositories, because they return parents as tuples and bdecode returns
> lists.
>    - It tries to use undefined RepositoryDataStreamError in case of
> invalid stream item key.
> 
> (Btw, why is insert_data_stream in Repository? The implementation is
> very knit-specific.)
> 
> There is one more revision in the bundle, but removing of the duplicate
> HeadsCache is so trivial that I don't think it deserves a separate merge
> request.
> 
> Lukas
> 
> 

BB:approve

It does seem like it could be moved down into KnitRepository (since
PackRepository inherits from it anyway).

I think at one point it was supposed to be implemented for all formats,
such that if the source and target formats are identical, you can use
this interface.

But Andrew would need to be the one to comment on that part.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHjn3xJdeBCYSNAAMRAvycAJ0b7OVpnnux5SHBq+n3ikjsS0rkQQCfVmf6
nAcN23lFYgKx75I4I78jDG0=
=xS6L
-----END PGP SIGNATURE-----