[MERGE] Speedup selftest by loading a previously saved test list

[Robert Collins]

On Fri, 2008-01-11 at 00:16 +0100, Vincent Ladeuil wrote:
> This patch add two options to the selftest command:
> 
> --save-list <file> 
> --load-list <file>
> 
> You use the first one to define a set of tests you want to run
> repeatedly and use the second one to avoid loading the whole test
> suite:
...
> - test inheriting from a class defined inside a function (or
>   using a lambda as an attribute) can't be pickled either (but
>   see the patch for some obvious fixes in the bzr core tests),
> 
> But overall I think more than 99% of tests can be used with this
> mechanism.

I feel pretty uncomfortable about this. You have to assume a great deal
to be sure that tests will execute the correct test when you are
pickling their state.

I'd rather not see this come in, it feels basically wrong. You should be
able to get nearly the same performance by saving just the names and
asking for just those tests.

bb:reject

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080115/aeaeabd8/attachment.pgp