[MERGE] Use a LRUCache in LocalTransport.clone

Robert Collins robertc at robertcollins.net
Mon Jan 14 23:26:42 GMT 2008


On Sat, 2008-01-05 at 01:41 +1100, Andrew Bennetts wrote:
> This is a simple change to use a LRUCache in LocalTransport.clone.  It seems
> that calculating an abspath can be quite expensive.  By keeping the LRUCache I
> reduce the time to pull a 300 revisions from a knit repo into a pack repo from
> ~32 seconds to ~26 seconds!

Thats nice, but why do we care? We're trying to migrate to packs and
conversions should be one-offs. It should not be any slower than knit to
knit cloning anyhow.

If clone() is slow and affecting our recommended formats, lets fix that.
But lets not add complexity because it is affecting our legacy formats.

bb:reject

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080115/cbffdfe3/attachment.pgp 


More information about the bazaar mailing list