[MERGE] Allow parent_providers to not have a get_parents attribute.
robertc at robertcollins.net
Fri Jan 11 00:17:38 GMT 2008
On Thu, 2008-01-10 at 18:27 -0500, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Robert Collins wrote:
> > On Thu, 2008-01-10 at 17:52 -0500, Aaron Bentley wrote:
> >> ParentProviders are a private API and we can freely remove anything we
> >> like from them. But Graph is not a private API, and it provides a
> >> get_parents method.
> > Graph does /not/ provide a get_parents
> > method. Graph *uses* the get_parents method on the object its composed
> > with.
> It does indeed provide a get_parents method. It just doesn't implement it.
> - From a caller's perspective, I don't seen any difference between
> ...The former just saves a function call.
> >> You can't just set the method to None some of the time.
> > I had been following suit with the previous API break (requiring
> > get_parents_map). I think, given that we have an API break but only
> > in .dev, that I'll do a full deprecation patch.
> If Graph.get_parents were not public, that would be one thing. But no
> one expects a public callable to sometimes be None.
Sure, can we move on from the None aspect? The point is that the current
status in 1.1 will break people that had implemented the API as
presented; and I'm writing a patch to fix that so that it will work.
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080111/51778779/attachment-0001.pgp
More information about the bazaar