[MERGE] Optimize find_branches for standalone repositories

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> Hi all,
>>
>> This patch optimizes find_branches by handing standalone repositories
>> specially, since they can't contain nested branches.

> Except you can quite easily have a grouping of standalone branches. And
> "bzr branches" finds them.

And it still does, even with this patch.

> I suppose it depends if your api is meant to be:
> 
> give me all branches sharing this repository
> 
> rather than
> 
> give me all branches underneath this url
>
> You seem to be advocating the former, but we really should be supporting
> the latter as well.

No, my comment was a bit unclear.  There is a boolean "using" that
determines whether we're finding all branches *below* the repository or
all branches *using* the repository.

This optimization only affects the *using* case.

> (I honestly can't say that I want people nesting
> standalone branches, but it should be something we support.)

In general, we treat standalone branches the same as repository
branches, and I agree we should do that here.  But we already do, so
that's all good.

Aaron

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHe6Ns0F+nu1YWqI0RAm+3AJ4xs3QJGjwbB+ZB+bVUtKOzwKXnKQCgiAFu
THZQ8fpeY5f9ISEnp/50PqE=
=G4P7
-----END PGP SIGNATURE-----