[MERGE] Misc fixes for win32

Aaron Bentley aaron at aaronbentley.com
Sun Dec 30 02:35:42 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

I decided to do some more work on win32.  The good news is that most of
our test failures are problems in the tests, not problems in the code
being tested.

In particular, it appears that it is not safe to call
WorkingTree.basis_tree() on an unlocked tree.  If this is done, later
calls to WorkingTree may attempt to lock the tree, causing lock contention.

Unfortunately, the HTTP tests are a real mess.  First of all, we're
getting socket errors, and if I handle the socket errors, then it tries
to do thread.join, and that blocks forever.  I don't have a lot of
experience with threads, so I hope someone else can have a look at this.

I had to make a few changes to the smart server protocol, because it
makes some incorrect assumptions.  It assumes that the only outcome from
doing get_files_bytes on a directory is ReadError, but on win32 (and
possibly Windows-based servers), you get PermissionDenied.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHdwP+0F+nu1YWqI0RAnyYAJwNZQdqqTBb2/uu2wapOY/CmMrU8wCfYNVk
y6Pnm3uuhplTU/xb/yvzZIY=
=XyoZ
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-mail-Rl1ze0.patch
Type: text/x-diff
Size: 14631 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071229/2110c48a/attachment-0001.bin 


More information about the bazaar mailing list