[MERGE] Implement diff --using natively
Aaron Bentley
aaron.bentley at utoronto.ca
Fri Dec 28 03:50:06 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert Collins wrote:
> bb:tweak
>
> please add some failure case tests:
>
> - missing tool
Okay
> - (possibly) tool does not accept options
How would you detect this? Exit codes? I don't know if there's enough
regularity for that. For example, gvimdiff produces exit code 1 when
given bad options, but for diff, exit code 1 means "files are different".
> And:
> - your tests require diff, please add a requireFeature call for a Diff
> feature.
Really? Which tests?
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHdHJt0F+nu1YWqI0RAgvHAJ9YEpiNyKVaujhEcyE4u5YyYatimACfU3uO
fFuQLxMW13b3/5T9tGidgBA=
=lAjS
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list