[MERGE] Even faster branching

Aaron Bentley aaron.bentley at utoronto.ca
Thu Dec 20 16:41:39 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> I'd like to see the accelerator_tree param documented in the docstrings
> of at least one of the public functions/methods, e.g. bzrdir.sprout,
> workingtree.initialize.

I've documented them all.

> Also, a few minor tweaks to the tests as noted
> below. Otherwise looks good to me.
> The calls to open_containing_tree_or_branch need to be replaced with
> calls to open_tree_or_branch. I'm guessing this was missed after a
> copy-and-paste. :-)

Fixed.  Thanks.

> As well as trapping and testing calls as you're doing, I'd like to see
> the contents of the files in the result tree explicitly tested for
> correctness.

Oops, missed this on my initial merge.  Merging now.

Thanks for your review.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHaptD0F+nu1YWqI0RAl+FAJwIvNIt56rmURwEdvdgfurqNw4k0wCeP9HP
/zhprf+46Lu35ToJBd3N1X0=
=ffRY
-----END PGP SIGNATURE-----



More information about the bazaar mailing list