[MERGE] Progress bar in InterDifferingSerializer.fetch()

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lukáš Lalinský wrote:
> On Po, 2007-12-17 at 21:09 -0500, Aaron Bentley wrote:
>> Aaron Bentley has voted resubmit.
>> Status is now: Resubmit
>> Comment:
>> Please add a test using an instrumented ProgressBar, as mentioned on the 
>> list.  Also, please follow the standard set by other ProgressBar users: 
>> no progress unless a ProgressBar is explicitly supplied.
> 
> Can you please point me to code that uses progress bars the right way?

workingtree.WorkingTree.revert
merge.Merger.__init__
merge.Merge3Merger.__init__
merge.merge_inner
repository.Repository.item_keys_introduced_by
transform.TreeTransform.__init__
transform.resolve_conflicts

> Because for instance other fetchers in fetch.py do:
> 
>         if pb is None:
>             self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
>             self.nested_pb = self.pb
>         else:
>             self.pb = pb
>             self.nested_pb = None
> 
> which forces a progress bar even if no was supplied. Another two uses
> I've found are either with DummyProgressBar (transform.py) or 'if pb is
> not None' (tree.py), but using the standard from other fetchers seems
> the the best option to me.

That seems reasonable.  I didn't realize that this deviation had become
established across all fetchers.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHZ8Gy0F+nu1YWqI0RAubQAJ49lxRzHGSX6yzdz4Qqgh0LAOavVgCfaqtq
0izjyBPa0fa2+nGK35frJ48=
=1e0+
-----END PGP SIGNATURE-----