error from bzr-rebase selftest

John Arbash Meinel john at arbash-meinel.com
Fri Dec 14 15:34:37 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Adam Mercer wrote:
> On Dec 14, 2007 9:16 AM, Jelmer Vernooij <jelmer at samba.org> wrote:
> 
>>> Is this anything to worry about?
>> Nope, this is a bug in the tests (caused by the return type of
>> revision_parents() changing) that has since been fixed.
> 
> Thanks, Jelmer
> 
> Cheers
> 
> Adam
> 
> 

Ah, that is because Knit repositories return parents as lists, and Pack
repositories return parents as tuples. I believe I understand why Robert went
with tuples (creating a tuple is significantly faster than a list, and his
index parsing generates tuples, so he mostly just returns them.) Still, it
would be nice to have standardized on one form.


The simple fix for the test is just to do:

assertEqual([xxx], list(repo.parent_names(revision)))

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHYqKNJdeBCYSNAAMRAgA8AKC7YVDbLChoBKWWh8bQt68Yg/SBSACbBT2Q
ngQgZxXNEOEP1zjAC9BWhfo=
=qFYR
-----END PGP SIGNATURE-----



More information about the bazaar mailing list