PQM Submission authors

Martin Pool mbp at sourcefrog.net
Thu Dec 13 02:24:19 GMT 2007


On Dec 12, 2007 1:24 AM, John Arbash Meinel <john at arbash-meinel.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> One point (a long time ago) I thought I remember us requesting that each PQM
> submission be prefixed with the author. Which I have continued to do. But it
> seems like Aaron, Robert and Vincent (and others?) have stopped doing that for
> a most submissions.
>
> I personally like seeing the author, as I actually make use of it. I always use
> "bzr log --short" to get a screenfull of information about what is going on, so
> I don't see whether a given change was made by Aaron or Robert, just "PQM".
> (Certainly we would like to change PQM to use --author, or maybe --submitter?.)

Well, really we should change it to use merge requests...

> Often the short commit message is marginally helpful, but seeing that it was
> done by Aaron is enough for me to attach it back to the Mailing list discussion.
>
> Also, when debugging, I will also use the author as part of my search. (Vincent
> submitted a patch for this a while ago, did it get merged?)
>
> If we decide not to do it, that is fine. But I would like to petition for 2
> things for pqm commit messages:
>
> a) "(Author Name) message". Their full name, spelled out, just for consistency.
> b) Patches which are specifically bug fixes should have "bug #XXXXX" in their
> commit message. This also has the advantage that Launchpad's revision view will
> link it correctly.
>
> See: https://code.edge.launchpad.net/~bzr/bzr/trunk

I support this, with a modification: because pqm commit messages need
to be only one line, I'd really prefer an unambiguous shorter nick
rather than a whole name.  ("Alexander Belchenko" or for that matter
"John Arbash Meinel" use up a fair fraction of a line :-)

I suggest unless someone objects you add this to the developer
document bit about using pqm.

-- 
Martin



More information about the bazaar mailing list