bzr log http+urllib does not work, http+pycurl is too slow

Vincent Ladeuil v.ladeuil+lp at free.fr
Wed Dec 12 20:56:13 GMT 2007


>>>>> "john" == John Arbash Meinel <john at arbash-meinel.com> writes:

<snip/>

Sorry, I had to send my previous email a bit too quick, it was
dinner time ;) And then I realized that if it was the wrong
layer, the upper one will be fine and better fitted to address
the uniqueness.

    john> What is wrong with a patch like this:

    john> === modified file 'bzrlib/transport/http/_urllib.py'
    john> --- bzrlib/transport/http/_urllib.py    2007-12-03 08:33:06 +0000
    john> +++ bzrlib/transport/http/_urllib.py    2007-12-12 18:26:34 +0000
    john> @@ -143,6 +143,10 @@
    john>              raise errors.InvalidHttpRange(abspath, range_header,
    john>                                            'Server return code %d' % code)

    john> +        if code == 200 and offsets:
    john> +            trace.warning('Got a 200 response when asking for multiple ranges'
    john> +                          ' does your server at %s support range requests?',
    john> +                          self.base)
    john>          data = handle_response(abspath, code, response.info(), response)
    john>          return code, data

Deal. (One layer too high though ;-)

Thanks for the feedback.

I'll fix some details and send a better patch asap in the
[bug #175886] thread.

    Vincent



More information about the bazaar mailing list