[MERGE][1.0] Fixes for find_differences() and get_parents_map()
Aaron Bentley
aaron.bentley at utoronto.ca
Wed Dec 12 14:21:19 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> "Re: [MERGE][1.0] Graph.heads() optimization... Now 1770x"
>> * contains Graph._preload_parents, but later merge requests retract it
>
> Hm... I thought I send the patches correctly. _preload_parents is only
> get_parents_map wrapped around get_parents. (Turn the list into a dictionary.)
> So there is no reason to have it if we have get_parents_map.
>
> There *was* a ParentsProvider.preload_parents() function which I completely
> removed. So whether on not a private helper function exists doesn't seem like
> it should block a review.
Sorry, I misunderstood.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHX+5f0F+nu1YWqI0RAt40AJ98ABfMu3uYtll1VlymBlByLGTulwCfab43
g4dEEQBxeTlHKivYIu/o5d0=
=lUIw
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list