[MERGE] Add contrib/bzr_access

Aaron Bentley aaron.bentley at utoronto.ca
Tue Dec 11 15:15:45 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> Aaron Bentley has voted resubmit.
>> Status is now: Resubmit
>> Comment:
>> At minimum, this needs a license before we can include it.  It would
>> also be nice to use ConfigObj rather than ConfigParser.
> 
> 
> Using 'ConfigObj' means it has to import bzrlib, but it is explicitly designed
> to be able to use a different bzr executable at runtime.

Well, that's not a requirement for merging.  But I think that it would
be nice
1. To standardize our file formats
2. To use a parser that can also update the file.

> I'm also not quite as convinced about our decision to use ConfigObj. It is
> currently one of the #1 slowdowns for startup performance. Specifically, its
> regex for supporting lists costs us a lot, and AFAIK we don't actually ever use
> it. We do lazy build that regex, but it doesn't matter because the first config
> file it parses forces all of those regex's to be used.

Startup performance definitely wasn't on the radar when I picked it.  It
was functionality:
- - read/write support
- - section nesting

Perhaps we should look for something else that has those
characteristics, or perhaps we should try to improve ConfigObj.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHXqmh0F+nu1YWqI0RApedAJ4yzc3TRXCOXuNsLsMXM8zd+nzT9wCdF6DN
qVtKHbddmSvsC/Lk1vkR1VY=
=evej
-----END PGP SIGNATURE-----



More information about the bazaar mailing list