PQM Submission authors

John Arbash Meinel john at arbash-meinel.com
Tue Dec 11 14:24:39 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

One point (a long time ago) I thought I remember us requesting that each PQM
submission be prefixed with the author. Which I have continued to do. But it
seems like Aaron, Robert and Vincent (and others?) have stopped doing that for
a most submissions.

I personally like seeing the author, as I actually make use of it. I always use
"bzr log --short" to get a screenfull of information about what is going on, so
I don't see whether a given change was made by Aaron or Robert, just "PQM".
(Certainly we would like to change PQM to use --author, or maybe --submitter?.)

Often the short commit message is marginally helpful, but seeing that it was
done by Aaron is enough for me to attach it back to the Mailing list discussion.

Also, when debugging, I will also use the author as part of my search. (Vincent
submitted a patch for this a while ago, did it get merged?)

If we decide not to do it, that is fine. But I would like to petition for 2
things for pqm commit messages:

a) "(Author Name) message". Their full name, spelled out, just for consistency.
b) Patches which are specifically bug fixes should have "bug #XXXXX" in their
commit message. This also has the advantage that Launchpad's revision view will
link it correctly.

See: https://code.edge.launchpad.net/~bzr/bzr/trunk

You can see that my submission 3101 has a hyperlink to bug #175337, but
Vincent's revision 3099 just has: Fix 173010 (no hyperlink).

I also use that a lot to do:

bzr log -r -100..-1 | vim -R -

and then search through it for the bug number. I could also do:

bzr log -r -100..-1 -m 'bug #\d+'

To see all the patches that address real bugs.

At a minimum, I would like to see "#XXXX" rather than just "XXXX".

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHXp2nJdeBCYSNAAMRAgrEAKCq07mf76XJDVfBjsOdHv7VpXjgIgCgrtYP
wcE+veIrgaXj6X2lS3K9xuA=
=L22X
-----END PGP SIGNATURE-----



More information about the bazaar mailing list