[MERGE] Uncommit doesn't throw when it encounters un-encodable characters

Aaron Bentley aaron.bentley at utoronto.ca
Tue Dec 11 14:06:16 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:

> We have a helper already to 'run_bzr' with a custom encoding. If you look in
> tests/blackbox/test_non_ascii.py:

Unfortunately, I used the log tests as my example.  Perhaps they should
be updated if they're doing it wrong.

> Especially since Uncommit should be using "get_terminal_encoding()" which only
> uses bzrlib.user_encoding as a fallback. So you may not actually be testing
> that uncommit is working properly.

I did TDD.  The test failed until I changed the encoding to 'replace'.
Ergo, I am testing the correct thing.  Since it doesn't have a terminal,
I wouldn't think run_bzr would have a terminal encoding.

But I will try changing it to run_bzr_decode, and submit the changes if
it works.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHXplY0F+nu1YWqI0RAs9iAJwNHikw6LX07zhHZfMmdlFFCD17WQCeK3TX
qjSoURJ01pb9TUUPDv0PW+I=
=UNAX
-----END PGP SIGNATURE-----



More information about the bazaar mailing list