multi-pull and repo-push commands failed with pack repo

Aaron Bentley aaron.bentley at utoronto.ca
Wed Dec 5 12:36:22 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> It seems that for some reason both plugins sometimes want to transfer
> the pack with name that already exists in destination repository. 
> The same plugin for knits repo wotks fine.

What happens when you use normal push or pull?

> And because you never get error during rename-over-top on Linux, IMO
> there is hidden bug in pack transfer code. Either win32 specific, or
> not. Any suggestions what it could be, and what the right way to fix it?

The pack transfer code is supposed to accommodate the case where there's
a pack file with the same name.  Since pack names are hashes, an
existing file with the same name has the same contents.

Since we don't want races, I believe the correct way to handle this
situation is to delete the file we are trying to rename, and pretend the
rename succeeded and overwrote the existing file.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHVptF0F+nu1YWqI0RAv0tAJ9v4LJYCBsqp2wdt6SxmzMkKwKqcACeJZnt
cA46hEsLGmwXIoXFKDTDVOI=
=ZCwm
-----END PGP SIGNATURE-----



More information about the bazaar mailing list