[MERGE] [BUG #165290] inter-pack fetch should make sure we aren't missing a compression parent

Robert Collins robertc at robertcollins.net
Fri Nov 30 20:57:59 GMT 2007


Robert Collins has voted tweak.
Status is now: Conditionally approved
Comment:
the _external_compression... method - on Pack I wouldn't mention 'new' 
texts - its all texts for that pack.

You check for missing texts outside Packer.pack(); I think it would be 
better to do this within Packer.pack; after it's this logic that will 
change to fetch arbitrary delta parents eventually etc.

This hunk looks suspect
=== modified file 
'bzrlib/tests/interrepository_implementations/__init__.py'
--- bzrlib/tests/interrepository_implementations/__init__.py 
2007-11-17 00:14:55 +0000
+++ bzrlib/tests/interrepository_implementations/__init__.py 
2007-11-29 22:27:29 +0000
@@ -103,9 +103,6 @@
                         knitrepo.RepositoryFormatKnit3()))
          result.append((InterKnitRepo,
                         knitrepo.RepositoryFormatKnit1(),
-                       knitrepo.RepositoryFormatKnit1()))
-        result.append((InterKnitRepo,
-                       knitrepo.RepositoryFormatKnit1(),


For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C20071130201555.3F94855FFA%40juju.arbash-meinel.com%3E



More information about the bazaar mailing list