Merging a bundle w/ a pack repository is slow

Martin Pool mbp at sourcefrog.net
Fri Nov 30 00:23:45 GMT 2007


> While I know that "get_ancestry()" is a -Devil function because it is
> O(history), it does seem like packs is punishing a lot of code for using it.
> (It is slow because it has a round trip into get_parents() for every node, and
> that is triggering _lookup_parent_by_location).
>
> If you call buffer_all (in the attached patch) it changes the time rather
> dramatically.

For me, this is a reasonable patch, and a reasonable justification.
It'll still be marked as something to avoid in future.

-- 
Martin



More information about the bazaar mailing list