[MERGE] Make mail-to address in ``bzr send`` optional for interactive mail clients

Lukáš Lalinský lalinsky at gmail.com
Wed Nov 28 17:36:43 GMT 2007


On St, 2007-11-28 at 12:03 -0500, Aaron Bentley wrote:
> Aaron Bentley has voted comment.
> Status is now: Waiting
> Comment:
> I think this is a great improvement-- it's now mostly following the rule 
> "Easier to ask forgiveness than permission".  But can't we follow it all 
> the way and remove the is_interactive check from cmd_send?  We'd just 
> rely on mail_client.compose_merge_request to raise 
> NoMailAddressSpecified.  is_interactive could go away, or at least 
> become private.

Good idea, it's nice how the simplest solutions are usually the best.
This updated version removes the check and MailClient.is_interactive.

Lukas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: send-optional-address.diff
Type: text/x-patch
Size: 6072 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071128/f03d9498/attachment.bin 


More information about the bazaar mailing list