[MERGE] Don't use sftp:// URLs as lp:/// translations when there's no Launchpad login.

James Henstridge james at jamesh.id.au
Wed Nov 28 04:51:45 GMT 2007


On 28/11/2007, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Jonathan Lange wrote:
> > On Nov 28, 2007 6:55 AM, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
> >> Aaron Bentley has voted reject.
> >> Status is now: Vetoed
> >> Comment:
> >> sftp may not work if you don't have a launchpad account, but you don't
> >> need to set it in the URL.
> >
> > Point taken.
> >
> > Note that this patch doesn't change the angle of approach -- the code
> > in bzr.dev does the same check for bzr+ssh. I'm updating it to be
> > consistent.
>
> Could you explain a bit more about why it's desirable?  It seems like we
> would always have an http url, so shouldn't we just pick it always?

We've got two classes of methods for accessing bazaar.launchpad.net:
 * those that can be accessed anonymously
 * those that require authentication

We want the anonymous methods to be picked if the user hasn't informed
Bazaar of their Launchpad credentials.

At present we suppress bzr+ssh to launchpad.net domains if we don't
know the credentials.  This patch just extends that to sftp as well.

As for why we don't just pick http for the anonymous case, the answer
is that http is not the only anonymous protocol available.  The
current setup makes it easier for us to roll out a more efficient
anonymous protocol (namely bzr:// or bzr+http://) without needing to
modify clients to take advantage of it.

The reason we are bothering with authenticated access to
bazaar.launchpad.net in the first place is simply to support
operations that require authentication (e.g. pushing to a branch).

James.



More information about the bazaar mailing list