[MERGE] Don't use sftp:// URLs as lp:/// translations when there's no Launchpad login.

Aaron Bentley aaron.bentley at utoronto.ca
Wed Nov 28 04:45:08 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> Jonathan Lange wrote:
>>>> On Nov 28, 2007 6:55 AM, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
>>>>> Aaron Bentley has voted reject.
>>>>> Status is now: Vetoed
>>>>> Comment:
>>>>> sftp may not work if you don't have a launchpad account, but you don't
>>>>> need to set it in the URL.
>>>> Point taken.
>>>>
>>>> Note that this patch doesn't change the angle of approach -- the code
>>>> in bzr.dev does the same check for bzr+ssh. I'm updating it to be
>>>> consistent.
>> Could you explain a bit more about why it's desirable?  It seems like we
>> would always have an http url, so shouldn't we just pick it always?
> 
>> Aaron
> 
> Because if you have bzr+ssh you can do:
> 
> bzr push lp:~user/project/branch
> 
> Which is shiny.

Okay.  But your lp username is only configured in ssh, then it will
select an http location, which is less shiny.

If it's really just a distinction between read and write, then maybe
that should be explicit here.  http will never be wrong for read (though
bzr+http would be nicer) and http will never be right for push.

So we can select URI based on what we need, and not based on
possibly-incorrect guesses about what we can use.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHTPJT0F+nu1YWqI0RApEvAKCIgYD7Cx/AkpSSJvUlsXqTrafRsgCdE6P7
oErhFAFGSwTiSuONP3VcrNQ=
=EJZP
-----END PGP SIGNATURE-----



More information about the bazaar mailing list