[MERGE] Don't use sftp:// URLs as lp:/// translations when there's no Launchpad login.
Aaron Bentley
aaron.bentley at utoronto.ca
Wed Nov 28 03:29:52 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Jonathan Lange wrote:
> On Nov 28, 2007 6:55 AM, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
>> Aaron Bentley has voted reject.
>> Status is now: Vetoed
>> Comment:
>> sftp may not work if you don't have a launchpad account, but you don't
>> need to set it in the URL.
>
> Point taken.
>
> Note that this patch doesn't change the angle of approach -- the code
> in bzr.dev does the same check for bzr+ssh. I'm updating it to be
> consistent.
Could you explain a bit more about why it's desirable? It seems like we
would always have an http url, so shouldn't we just pick it always?
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHTOCw0F+nu1YWqI0RApOCAJ4qgzpt5cv+nPn1D4ZDo6UFD5S+LgCeLdPy
J2cNsLMXsEQU+vy2WgRmbSU=
=Tx+e
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list