[MERGE] Make mail-to address in ``bzr send`` optional for interactive mail clients

Lukáš Lalinský lalinsky at gmail.com
Mon Nov 26 21:34:36 GMT 2007


On Po, 2007-11-26 at 14:48 -0500, Aaron Bentley wrote:
> I think it's okay to omit the address for the interactive clients, but 
> it would be much better if it was just set for the branch so that it 
> wasn't needed.
> 
> DefaultMail is not necessarily interactive.  It falls back to the editor 
> client.  Your code will make it claim to be interactive, which will 
> break if it falls back to the editor.

Fixed. I also had to mark XDGEmail as non-interactive, because it
requires the mail-to address on the command line. This shifts the
meaning of is_interactive(), but I can't think of a better name for the
method.

Lukas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-send-address.diff
Type: text/x-patch
Size: 10530 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071126/01315f9d/attachment.bin 


More information about the bazaar mailing list