[MERGE] Updated more-packs-default-fixes.
Robert Collins
robertc at robertcollins.net
Mon Nov 26 20:28:46 GMT 2007
review meta-request.
please keep the file headers intact. Finding arbitrary text across the
code base ain't *that* trivial.
Thanks for the review.
On Mon, 2007-11-26 at 02:57 -0500, Martin Pool wrote:
>
> + ## We used to do this for knits, so that invidual methods
> could
> be
> + ## accelerated, but actually this was in hindsight a bad
> idea.
> Because
> + ## really we do need the real repository to assemble the
> work
> it's own
> + ## way.
> + ## # Make the builder use this RemoteRepository rather than
> the
> real one.
> + ## builder.repository = self
>
> s//individual/
>
> I'm not sure why this has ##, normally I use them for temporarily
> disabled
> code (though that's not a standard afaik.)
I was thinking about it still; I'll delete the lines now as you don't
mind the code change.
>
> def dont_leave_lock_in_place(self):
> + if not self._lock_token:
> + raise NotImplementedError(self.leave_lock_in_place)
> self._leave_lock = False
>
> again
>
> + # The branch should have asked the rpeository to lock.
>
> repository
>
> + def assertRepositoryHasSameItems(self, left_repo, right_repo):
>
> nice.
>
> i might have called it 'assertRepositoriesHaveSame...' but either is
> ok.
>
> + """require left_repo and right_repo to have the same
> value."""
>
> "contain the same data"?
Uhm, if you like. I'm trying to decouple representation and content.
E.g. ideally it will say they are the same format but allow for the pack
contained data to be in reverse order. I've changed it to your
suggestion for now.
-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071127/1459c72c/attachment.pgp
More information about the bazaar
mailing list