[MERGE] Refactor diffing

Aaron Bentley aaron.bentley at utoronto.ca
Sun Nov 25 21:54:31 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> I'm really happy with this code. The only remaining thing I think could
> be improved would be for the factory signature to take DiffTree rather
> than the individual trees. Then DiffKindChange can share the signature
> and there's no need to special case it.

I've added a from_diff_tree factory to each Diff class.  But as you can
see, it doesn't simplify things too much.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHSe8X0F+nu1YWqI0RAqyTAJ9zmXZtOaW94mRoawDi16zIE6IM/QCfY9Pv
5xXm5mnt2U4m9/ZpnrytiHM=
=ChlD
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: refactor-diff-6.patch
Type: text/x-diff
Size: 54441 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071125/549a9f8c/attachment-0001.bin 


More information about the bazaar mailing list