[MERGE][Bug #84043] Commit now invokes an external editor in non-ASCII directories

Aaron Bentley aaron.bentley at utoronto.ca
Tue Nov 20 02:47:55 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Watkins wrote:
> On Sat, 17 Nov 2007 10:43:07 -0600
> John Arbash Meinel <john at arbash-meinel.com> wrote:
>> msgfilename, msgfileno = mkstemp(..., dir='.')
>> msgfilename = osutils.basename(msgfilename)
>> msgfile = os.fdopen(msgfileno)
> Done in attached.
> 
> I've also modified the test to use EncodingAdapter, as well as adding
> to the test suite in general to allow the loading of a specific test.
> This necessitated the addition of a TestSkipped to the test in
> question, for the case when it wasn't being run adapted.

bb:tweak

I think this is more of case of TestNotApplicable, since constructing a
test without this info is basically incoherent.

I'd prefer to avoid running this when we know it can't pass, but I don't
think it's worthwhile creating a new test module for a single test.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHQkrb0F+nu1YWqI0RAoPSAJ4rbb1U/v6OBdN18DgbSwHCUW9qIACfV93X
SVbk4N1p7iNBwuiORbUr+x0=
=x6P4
-----END PGP SIGNATURE-----



More information about the bazaar mailing list