[MERGE] Rename on Windows is able to change filename case. (#77740)

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
>> What happens if we do failUnlessExists?
> 
> failUnlessExists for case-insensitive filesystem never fail for test
> that change case.
> But that comment actually incorrect. Probably you tries to say me so.
> We can't use failIfExists on case-insensitive filesystem, actually.
> I'll change it.

I was actually confused, but that makes sense.

>> Also, instead of making this a workingtree4 test, I think it should be a
>> workingtree_implementations test, because we'll want future formats to
>> support this.
> 
> In this case I need to implement case-sensitive detection for all existing
> wt formats. It's not hard, I just think it's redundant.

I would be fine with skipping those tests for explicitly-named old tree
formats.  But I really think it makes sense for future formats.

>>> +            elif (self.cifs and has_from_rel
>>> +                and from_rel.lower() == to_rel.lower()):
>>>                  only_change_inv = False
>> Perhaps it would be cleaner to introduce WorkingTree.is_same_file() or
>> something?  I just think that every use of the .cifs var is likely to be
>> testing whether two files are the same.
> 
> I'm not sure here, maybe you're right.

Possibly TreeTransform would use the cifs var directly, because it needs
to determine whether filenames will clash before actually renaming them.

But for other uses, it would be a nice convenience, and I think it would
be clearer.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHQimU0F+nu1YWqI0RArT4AJ9m5FhK0Ojoy/+zyEd78RrivQSivwCeKW+5
bFX7tQ8kX6aVQ1vTTAHOgDA=
=WhFN
-----END PGP SIGNATURE-----