[MERGE][bug #151208] Upgrade util/configobj to version 4.4.0

John Arbash Meinel john at arbash-meinel.com
Mon Nov 19 19:30:16 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matt Nordhoff wrote:
> Vincent Ladeuil wrote:
>>>>>>> "Matt" == Matt Nordhoff <mnordhoff at mattnordhoff.com> writes:
>>     Matt> Vincent Ladeuil wrote:
>>     >> Nothing has changed regarding bzr needs, tests are still passing,
>>     >> bug #149019 (which could have been avoided by this upgrade did
>>     >> not regress).
>>     >> 
>>     >> The code is slightly shorter, the internal tests having been
>>     >> moved to a specific file.
>>
>>     Matt> I know it doesn't matter, but in test_config.py, why not "from
>>     Matt> bzrlib.util.configobj import configobj"? PEP 8?
>>
>> I tried that but it doesn't work in that case.
> 
> Huh!

It doesn't? It seems to be working here:
>>> from bzrlib.util.configobj import configobj
>>> configobj
<module 'bzrlib.util.configobj.configobj' from
'bzrlib/util/configobj/configobj.py'>

Is it something to do with the new version of ConfigObj?

> 
>>     Matt> Also, why not try importing configobj and only use
>>     Matt> bzrlib.util.configobj if it's not available?
>>
>> Because we test against the embedded version and I see little
>> interest in taking the risk of a backward or forward incompatible
>> change.

There is also a small performance hit for searching through PYTHONPATH for a
module. It should be faster to find "bzrlib.util.configobj" because it
shouldn't have to search the whole path.

I don't know that it is critical, but try "bzr --profile-imports cmd" sometime.
It can be a bit shocking how much stuff we go out and grab. Note: this only
works when running from source, because we don't install the profile_imports.py
script. I didn't want to put it under 'bzrlib' because bzrlib has side effects
(loads locale, etc) and I wanted those measured.
It also looks like profile_imports.py could use a bit of attention (it should
search for python2.5, etc.)

John
=:->

> 
> Oh, good point. Never mind.
> 
> Still, could do it in config.py.
> 
> Anyway, I'll shut up now.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHQeRIJdeBCYSNAAMRAvNWAJ47PboGAwuKLP3JSEvuF1YO7Ku+UgCfQfbK
ucJ31gK9nS3wDD6BgrrfEKA=
=cotc
-----END PGP SIGNATURE-----



More information about the bazaar mailing list