[MERGE] migrate switch command into the core

Ian Clatworthy ian.clatworthy at internode.on.net
Fri Nov 16 06:49:16 GMT 2007


Robert Collins wrote:

> I haven't looked at this yet, but I think it should be given the full
> normal review; if you've just grabbed the code and not done a review
> yet, can I ask that that be the first thing you do - we do this on all
> code coming in, and my feeling is that if Aaron had felt it was ready
> for bzrlib he would already have submitted it :).

bb:tweak

It's a good point. I won't speak for Aaron but the code looked good
enough as it was to put up. If I was reviewing it, I'd probably ask for
another test or two (e.g. a blackbox one checking the error message when
a non-existent location was given) and better docstrings.

Ian C.



More information about the bazaar mailing list