[MERGE] _generate_text_key_index

Robert Collins robertc at robertcollins.net
Thu Nov 15 21:42:23 GMT 2007


On Fri, 2007-11-16 at 08:23 +1100, Robert Collins wrote:
> This is the LRU cache enabled _generate_text_key_index. It performs,
> IMNSHO, reasonably well.
> 
> I'm now working on actual reconcile integration, at which point I'll be
> able to compare the two codebases and ensure that this is actually a
> performance improvement.
> 
> I'd like to get this review though, even if not merged until the group
> is completed.

this does not finish the pb it uses, I'm splitting out a helper to do
this cleanly. Other than that I think its fine.

It made me think though, what do 'you' think of an @with_progress
decorator. This would:
 - create a nested pb.
 - pass it in as a kw arg to the decorated function
 - call finished() on it automatically.

?

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071116/644e69b7/attachment.pgp 


More information about the bazaar mailing list