[MERGE][bug #168819] Detect invalid transport reuse attempts by catching invalid URLs.

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
>>>>>> "john" == John Arbash Meinel <john at arbash-meinel.com> writes:
> 
>     john> I have a checkout of a local branch, and pull from a remote host. And it gave me:
>     john> Using saved location: http://panoramicfeedback.com/opensource/bzr/bzrtools
>     john> http://panoramicfeedback.com/opensource/bzr/bzrtools/ is redirected to
>     john> http://panoramicfeedback.com/opensource/bzr/repo/plugins/bzrtools/
>     john> bzr: ERROR: Invalid url supplied to transport: "Host empty in:
>     john> /srv/bzr/public/mirrors/plugins/bzrtools/mainline/"
> 
>     john> It seems that the bug is in Transport._reuse_for()
> 
> It was.
> 
>     john> it is calling ConnectedTransport._split_url(), which
>     john> was recently modified to give an error when there is no
>     john> Host.
> 
> And you told about possible use for local transports when you
> reviewed the patch doing that...

Yeah, but we weren't really thinking about _reuse_for, just for get_transport().

Anyway
BB:approve

John
=:->


> 
> The attached trivial patch fixes that,
> 
>     Vincent
> 
> P.S.: I deleted a duplicated entry in NEWS, while it may seem
> important to remind people that HttpServer do not use timeouts
> anymore, saying it twice seems a bit too much ;)
> 
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHOw0zJdeBCYSNAAMRAqToAJ99NKPVKbDqYstVEzbZC7lghhS2DQCgra16
jasqKEEdkEB0h6KR3fpIN/Q=
=0IWj
-----END PGP SIGNATURE-----