[MERGE] Automatic discovery of tests

John Arbash Meinel john at arbash-meinel.com
Tue Nov 13 21:51:00 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Tue, 2007-11-13 at 15:44 -0600, John Arbash Meinel wrote:
>> Robert feels iffy about having the tests automatically found, because
>> of tests
>> not getting run if they aren't found. However, we already are
>> auto-loading the
>> tests from files that we list. So it isn't introducing any new
>> problems. In
>> fact, I think it is closing a hole where we add the tests, but forget
>> to update
>> the lists. 
> 
> It trades holes; the current hole the submitter will see their tests
> fail to run. In the substituted hole PQM will fail to see the tests run
> - and PQM doesn't care.
> 
> I think the current hole is better.
> 
> -Rob

I think reviewers seeing that there are no tests is better than reviewers
failing to see that the user didn't add a line.

If it were purely based on holes, then I would agree with you.

However, there is also the convenience factor. Having to add an extra line is a
bit of inconvenience. It may not be huge now that the bzr test suite is fairly
stable. But I know that this sort of thing is very useful when writing a
plugin, and adding 10+ new test_* files.

I would imagine that when adding a new *_implementations test suite, it would
also similarly be very helpful.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHOhxEJdeBCYSNAAMRAujnAJ4pcnvDeEysN2YjmBRSG5wKFceakQCggnmU
U2ZUvbKX6O57m8BzIS9OU4c=
=n/pt
-----END PGP SIGNATURE-----



More information about the bazaar mailing list