[MERGE] fix formatting of ImmortalPendingDeletion error message.

John Arbash Meinel john at arbash-meinel.com
Tue Nov 13 21:05:05 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Robert Collins ?8H5B:
>> On Tue, 2007-11-13 at 13:05 +0200, Alexander Belchenko wrote:
>>> Today I ran 'bzr up' in bound branch and got unprintable exception error:
>>> ..
>>> So I'm writing test and fix for this case.
>> bb:resubmit
> 
>> Your patch's new helper function is interesting, but it seems a lot
>> harder than just using the current pattern for testing formatting of
>> errors:
>>  - e = SomeError(params)
>>  - self.assertEqual(expected_string, str(e))
> 
>> So I'd prefer you just did that.
> 
> You're right.
> Here simpler version of my patch.

bb:approve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHOhGBJdeBCYSNAAMRAv/oAJ0UTzthY5Gfv/GPH6NGq3/JE84PlwCgih+/
BaPNpLrYbBtsa/imJOTdW+U=
=18rw
-----END PGP SIGNATURE-----



More information about the bazaar mailing list