[MERGE] Use normalize_log to more accurately test blackbox log output.

Kent Gibson warthog618 at gmail.com
Tue Nov 13 13:01:00 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Since I've been poking around in the test_log recently I noticed one
or two things that I felt could be improved.

This probably isn't the "nice pattern matcher" that Robert Collins had
in mind, it is applying the log normaliser already used in
tests/test_log to the blackbox log tests.
I find this approach clearer, more accurate and easier to maintain
than the ad hoc pattern matching that  was being used.  e.g. note the
old tests check for revno "1.1.1.1", which should be "1.1.1.1.1".

There are also a couple of places where I have swapped the order of
the params to EqualDiff so the output if there is an error shows what
is missing from or additional in the generated log.

And finally a couple of coding standard fixes.

Since this is just a minor internal tidy up I haven't bothered with a
NEWS entry.

Cheers,
Kent.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHOaALgoxTFTi1P8QRAj7xAJ9zpeZ0U4xcGrVcXwgWwz7ceU98OgCgmJQp
vh+sQvVAU6rYf7+i6jfUcfk=
=Or+e
-----END PGP SIGNATURE-----

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-mail-1SRnw_.patch
Type: text/x-patch
Size: 15632 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071113/b880fd42/attachment-0001.bin 


More information about the bazaar mailing list