[MERGE] Rename on Windows is able to change filename case. (#77740)

Alexander Belchenko bialix at ukr.net
Tue Nov 13 06:26:50 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley пишет:
> Alexander Belchenko wrote:
>> Aaron Bentley ?8H5B:
>>> Alexander Belchenko wrote:
>>>> I'm also like to see the complete fix, but we need some way
>>>> to detect case-insensitivity first.
>>> I'm not sure that's true.  We could handle it this way:
>>> rename target -> tmp (success)
>>> rename src -> target (failure)
>>> rename tmp -> target (success)
>>> We would be subject to race conditions, but fancy_rename already is.
>> What about this variant for fancy_rename:
> 
> I like it.

Updated patch attached.

>> +        except (IOError, OSError), e:
>> +            # case insensitive filesystem may be?
>> +            if (not file_existed
>> +                or e.errno not in (None, errno.ENOENT, errno.ENOTDIR)):

> Why would we get ENOTDIR?

Still don't know. Maybe anybody else could shed light on this?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHOUOqzYr338mxwCURAtAvAJ9yb4xFBOAxam+1THnqu/R88sGDmwCfX+/w
K9hiDpy6S98PH5sBV6B14gY=
=efiY
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mv.change.case.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20071113/85d5fb4d/attachment-0001.diff 


More information about the bazaar mailing list