[MERGE] [Bug #133751] Fix traceback thrown by ``bzr log -r 0``

Kent Gibson warthog618 at gmail.com
Mon Nov 12 23:25:34 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Aaron Bentley wrote:
> Aaron Bentley has voted reject. Status is now: Vetoed Comment: I
> think if the user requests revision 0, we should politely tell them
> that it doesn't exist.  None means "no value specified", not
> "unreasonable value specified", and NULL_REVISION shouldn't have
> the same behavior.  "bzr log -r0" is not the same thing as "bzr
> log"
>
Hmmm, ok.  That wasn't how I read John's comments in the bug.

So the real problem is that -r 0 is being mapped to into the
NULL_REVISION?
Oh, and that show_log should handle NULL_REVISION as it presently
handles None (which should no longer be passed??).

I'll take another look.

Cheers,
Kent.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHOODtgoxTFTi1P8QRAkKNAKC6c24s4y15qAJbBS3VR/NGoJgofACgxcO6
PyS0S8bHMTSjXupQCFZJ1ck=
=qfD3
-----END PGP SIGNATURE-----



More information about the bazaar mailing list