[MERGE] [Bug #148908] Return an error if the revisionspec contains merge revisions, but the log formatter doesn't support them.

Kent Gibson warthog618 at gmail.com
Mon Nov 12 11:37:23 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This is a pretty straight forward fix for #148908.
It adds a precondition check that the revision specs for log
formatters that don't support merge revisions are mainline revisions.
The precondition check has a very minor performance hit (one or two
dict lookups) on logs with formatters that don't support merge
revisions and where a revisionspec is provided.
I toyed with the idea of handling the exception raised by
_filter_revision_range instead, but this solution looked cleaner to me.

Cheers,
Kent.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHODrxgoxTFTi1P8QRAnJDAKC90rXSvuD+zeQN9uwUXXaympWcVgCg8PFu
GvlRvnPDJY+RuykCAU0p2ys=
=3XE/
-----END PGP SIGNATURE-----

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-mail-Hws6Qz.patch
Type: text/x-patch
Size: 4781 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071112/b92dde4f/attachment-0001.bin 


More information about the bazaar mailing list