[MERGE] Output refactoring and XML integration into bzrlib

John Arbash Meinel john at arbash-meinel.com
Sat Nov 10 11:43:40 GMT 2007


John Arbash Meinel has voted comment.
Status is now: Waiting
Comment:
I haven't had a chance to go through all of the details, but I did 
glance over it.

I think having an abstraction layer could be really good, as it lets you 
do more semantic comments, rather than raw formatting.
On the flip side, we should at least be aware if it is going to be a 
performance issue. I'm guessing it won't, but the overhead of turning a 
simple write() into 3+ calls (one call into the log function, and then 
three into the _start/_do_it/_end) seems like it could be a bit much. 
Though I think most of those have a loop in the _do_it, which should 
balance that out.

I just wanted to comment that you have a lot of PEP8 issues.

Like top-level entries should have 2 blank spaces in-between them. You 
have a file with no newline at the end, etc.

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C2422be180711092224n147ed658s49606bf8147a020b%40mail.gmail.com%3E



More information about the bazaar mailing list