[MERGE] remove 'branch-name' from format 6 branches

John Arbash Meinel john at arbash-meinel.com
Thu Nov 8 23:13:41 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

We have a file which is a bit of cruft in Branch6 branches. Namely
'.bzr/branch/branch-name'.

It isn't actually used for anything (in fact, I can't see it being used anymore
in even Branch5 formats).

It doesn't make a huge difference to most people, if you have an empty file
sitting around. But I was working on converting a large project, and every file
actually consumes a 4k disk block. And when you have thousands of branches,
that ends up costing MB of disk (1000 branches == 4MB of disk waste).

It is a pretty simple patch, though I haven't really run the test suite to see
if there are tests that the file exists. If there are, it should be easy to fix.

=== modified file 'bzrlib/branch.py'
- --- bzrlib/branch.py    2007-10-11 04:54:04 +0000
+++ bzrlib/branch.py    2007-11-08 23:10:24 +0000
@@ -1146,7 +1146,6 @@
     def initialize(self, a_bzrdir):
         """Create a branch of this format in a_bzrdir."""
         utf8_files = [('last-revision', '0 null:\n'),
- -                      ('branch-name', ''),
                       ('branch.conf', ''),
                       ('tags', ''),
                       ]


John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHM5gkJdeBCYSNAAMRAltXAKC03NDbPFJLEN6L4mVT8wGI9HjN/gCglO2I
bH/Ffj2sZppWJHHjVi4YaDo=
=yzYJ
-----END PGP SIGNATURE-----



More information about the bazaar mailing list