[MERGE] Re-enable the WT4._iter_changes fast path against the null: parent

Robert Collins robertc at robertcollins.net
Wed Nov 7 19:44:53 GMT 2007


bb:comment
On Tue, 2007-11-06 at 17:57 -0600, John Arbash Meinel wrote:
> 
> There was only one failing test. And that was that when the repository
> didn't
> support nested trees, we shouldn't report that they existed.
> 
> I don't know for sure how that test was passing, since the fast-path
> code was
> set up to always report tree-reference.
> 
> The attached patch fixes both pieces. Re-enabling fast-path when
> parent is
> 'null:', and making sure we don't report 'tree-reference' when the
> repository
> hasn't enabled it.

I'm not sure if this should report tree-reference or not. I previously
held the opinion that it was higher level code that should enforce such
a policy (even though it would still be looking at the repo etc for
support).

I don't really have an option on the issue either way or not.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071108/2acfcf96/attachment.pgp 


More information about the bazaar mailing list