bzr 0.92.0.candidate.1 BUG

Robert Collins robertc at robertcollins.net
Wed Nov 7 13:29:39 GMT 2007


On Wed, 2007-11-07 at 07:08 -0600, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> > On Tue, 2007-11-06 at 12:03 -0600, John Arbash Meinel wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> Robert Collins wrote:
> >>> Why is the temp file name something that needs encoding ?
> >>>
> >>> -Rob
> >> Because the current working directory has non-ascii names.
> >>
> >> Such as:
> >>
> >> cd path/to/جوجو/
> >> bzr commit
> >>
> >> We create a bzr_log file in the current working directory.
> >>
> >> I think we chose that because we wanted to leave them there to be re-used in
> >> case something failed.
> > 
> > Well, if the current working dir was in a non-ascii name it would be ok.
> > I think what you mean is 'the root of the tree is in a non-ascii name' -
> > we don't write to '.', we write to $(bzr root).
> > 
> > -Rob
> 
> No, actually we use:
>     tmp_fileno, msgfilename = tempfile.mkstemp(prefix='bzr_log.',
>                                                dir=u'.',
>                                                text=True)
> 
> Which puts the "bzr_log" file into the current working directory.
> 
> Which means you can actually work around it with:
> 
> cd path/to
> bzr commit جوجو
> 

This seems kindof weird to me then - if the filename is always relative
to cwd, why are we using the full path and thus having to [en|de]code.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071108/d398615a/attachment.pgp 


More information about the bazaar mailing list