[MERGE] Re-enable the WT4._iter_changes fast path against the null: parent

John Arbash Meinel john at arbash-meinel.com
Tue Nov 6 23:57:40 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> WT4._iter_changes was originally designed to support comparison against
> 'null:'. For whatever reason it was disabled, but this patch reverts that
> to re-enable it.
> 
> This has an effect on some of our benchmarks, because the non-fast path
> doesn't update the hash cache. Which means that multiple "bzr status"
> calls stay slow.
> 
> It is a fairly minor change, but I haven't run the full test suite to make
> sure nothing breaks. (It is currently running.)
> 
> John
> =:->

There was only one failing test. And that was that when the repository didn't
support nested trees, we shouldn't report that they existed.

I don't know for sure how that test was passing, since the fast-path code was
set up to always report tree-reference.

The attached patch fixes both pieces. Re-enabling fast-path when parent is
'null:', and making sure we don't report 'tree-reference' when the repository
hasn't enabled it.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHMP9zJdeBCYSNAAMRAmntAJ4lVhTVHA85sJL4tr0zP2zdRnPPzACgsNDF
dHTEp39AfOA5d/hdRd/SzHc=
=1slM
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fast_diff_versus_empty.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20071106/67fce43c/attachment-0001.diff 


More information about the bazaar mailing list