bzr rm directoryname crash

[Kent Gibson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Warren,

That is certainly a bug.  I haven't debugged it fully but a None is
being passed to Globster.match which expects a filename.  That only
appears to happen if there are pending  (uncommitted) removed files in
the directory being deleted, as in your case.

A quick workaround is to do this:

bzr revert config
bzr rm config

The revert will restore the file you deleted.
The rm config will remove the directory and all contained files.

Someone want to investigate this further and/or raise a bug - I've got
to head off to work.
Will have another look at it later if no one else does.

Cheers,
Kent.

Warren Togami wrote:
> I did "bzr rm file" in directory "config", then tried "bzr rm
> config" when this crash occurred.
>
> Warren Togami wtogami at redhat.com
>
> [warren at newcaprica ltsp5]$ bzr rm config/ bzr: ERROR:
> exceptions.TypeError: expected string or buffer
>
> Traceback (most recent call last): File
> "/usr/lib64/python2.5/site-packages/bzrlib/commands.py", line 800,
> in run_bzr_catch_errors return run_bzr(argv) File
> "/usr/lib64/python2.5/site-packages/bzrlib/commands.py", line 758,
> in run_bzr ret = run(*run_argv) File
> "/usr/lib64/python2.5/site-packages/bzrlib/commands.py", line 492,
> in run_argv_aliases return self.run(**all_cmd_args) File
> "/usr/lib64/python2.5/site-packages/bzrlib/builtins.py", line 1121,
>  in run force=file_deletion_strategy=='force') File
> "/usr/lib64/python2.5/site-packages/bzrlib/mutabletree.py", line
> 50, in tree_write_locked return unbound(self, *args, **kwargs) File
>  "/usr/lib64/python2.5/site-packages/bzrlib/workingtree.py", line
> 1847, in remove if not self.is_ignored(path[1]) and ( File
> "/usr/lib64/python2.5/site-packages/bzrlib/workingtree.py", line
> 1604, in is_ignored return self._ignoreglobster.match(filename)
> File "/usr/lib64/python2.5/site-packages/bzrlib/globbing.py", line
>  213, in match match = regex.match(filename) TypeError: expected
> string or buffer
>
> bzr 0.91.0 on python 2.5.1.final.0 (linux2) arguments:
> ['/usr/bin/bzr', 'rm', 'config/']
>
> ** please send this report to bazaar at lists.ubuntu.com
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHL6DxgoxTFTi1P8QRAil4AKDrelqkalIHm7kdv4ia9MC7E9hNgACeMZ/d
E0G2ufty2wmkpR7G83NRi+A=
=3yJz
-----END PGP SIGNATURE-----