[Preview/RFC] win32 fake symlinks

Alexander Belchenko bialix at ukr.net
Sat Nov 3 14:49:04 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil пишет:
>>>>>> "bialix" == Alexander Belchenko <bialix at ukr.net> writes:
> 
> <snip/>
> 
>     bialix> 2) I provide fake symlinks in format that understand
>     bialix> Cygwin. So people who like to run bzr.exe on Cygwin
>     bialix> should be happy. Though Cygwin itself creates links
>     bialix> (with ln -s) as windows shortcuts, that have extra
>     bialix> '.lnk' extension. No support for such shortcuts is
>     bialix> provided because I concerned about speed. So if you
>     bialix> need to create fake symlinks either on pure Windows
>     bialix> or on Cygwin I provide new hidden command 'symlink',
>     bialix> as equivalent to 'ln -s TARGET NAME'.
> 
> Since this is windows specific, I think you should either
> activate it on windows only, hint that in the name
> (windows-symlink) or do both.

Actually it's not windows-specific. This command will work on Linux too.

> 
>     bialix> 3) To allow bzr using fake symlinks on win32 I
>     bialix> monkeypatching os module. I'm hardly convinced that
>     bialix> monkeypatching here is right thing, because no-one
>     bialix> Linux developer will care to use
>     bialix> osutils.[symlink|readlink|lstat] instead of
>     bialix> os.[symlink|readlink|lstat].
> 
> We have rules harder than this one to follow...
> 
>     bialix> And I don't want forever go behind you guys as
>     bialix> street-cleaner an fix all places where you write
>     bialix> win32-incompatible code.
> 
> One solution will be to monkeypatch the os ones with versions
> raising deprecation warnings and point people to the osutils
> ones.

But anyway I should monkeypatch os module. So, where benefits?
Only more code for me.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHLIpgzYr338mxwCURAjlJAJ9yvOa/X18Mz+kDQHnbIrlTYzbx+gCeP9px
w+jHt+BcBrBADoKNNgd6GJ0=
=DQfM
-----END PGP SIGNATURE-----



More information about the bazaar mailing list