[MERGE] selftest: use SymlinkFeature instead of TestSkipped where appropriate

Vincent Ladeuil v.ladeuil+lp at free.fr
Thu Nov 1 15:10:46 GMT 2007


>>>>> "john" == John Arbash Meinel <john at arbash-meinel.com> writes:

    john> Alexander Belchenko wrote:
    >> John Arbash Meinel пишет:
    >>> Alexander Belchenko wrote:
    >>>> These changes are mostly mechanical.
    >>>> 
    >>>> Alexander
    >>>> 
    >>> 
    >>> BB:tweak
    >>> if getattr(os, 'mkfifo', None) is None:
    >>> - -            # TODO: Ultimately this should be TestSkipped
    >>> - -            # or PlatformDeficiency
    >>> - -            return
    >>> +            raise TestSkipped('OS does not support mkfifo')
    >>> 
    >>> ^- I think we want a comment that this should be an 'UnavailableFeature'
    >> 
    >> OK, it's doable. Will do.
    >> 
    >>> 
    >>> +        raise TestSkipped('pycurl do not check HTTP_PROXY '
    >>> +            'for security reasons')
    >>> 
    >>> ^- This should be: pycurl does not ...
    >>> 
    >>> (including in the nearby comment.)
    >> 
    >> I'm copy-pasting from the comment above, so it's not my fault.
    >> 

    john> I'm not blaming you, I recognize it as a typo from Vincent. But we should still
    john> fix them when we see them.

At least HTTP was spelled correctly...

   Vincent



More information about the bazaar mailing list