[MERGE] selftest: use SymlinkFeature instead of TestSkipped where appropriate
John Arbash Meinel
john at arbash-meinel.com
Thu Nov 1 14:16:37 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Alexander Belchenko wrote:
> John Arbash Meinel пишет:
>> Alexander Belchenko wrote:
>>> These changes are mostly mechanical.
>>>
>>> Alexander
>>>
>>
>> BB:tweak
>> if getattr(os, 'mkfifo', None) is None:
>> - - # TODO: Ultimately this should be TestSkipped
>> - - # or PlatformDeficiency
>> - - return
>> + raise TestSkipped('OS does not support mkfifo')
>>
>> ^- I think we want a comment that this should be an 'UnavailableFeature'
>
> OK, it's doable. Will do.
>
>>
>> + raise TestSkipped('pycurl do not check HTTP_PROXY '
>> + 'for security reasons')
>>
>> ^- This should be: pycurl does not ...
>>
>> (including in the nearby comment.)
>
> I'm copy-pasting from the comment above, so it's not my fault.
>
I'm not blaming you, I recognize it as a typo from Vincent. But we should still
fix them when we see them.
>>
>>
>> The rest looks good.
>>
>> John
>> =:->
>
>
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHKd/FJdeBCYSNAAMRAlWjAJ4q1Pm7IZYQq8SqJXzJCB13loYoMwCeKgAj
OtYu6AbfHeoNWrRRGQhIQTU=
=aFA+
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list