[MERGE] selftest: use SymlinkFeature instead of TestSkipped where appropriate
Alexander Belchenko
bialix at ukr.net
Thu Nov 1 14:06:43 GMT 2007
John Arbash Meinel пишет:
> Alexander Belchenko wrote:
>> These changes are mostly mechanical.
>>
>> Alexander
>>
>
> BB:tweak
> if getattr(os, 'mkfifo', None) is None:
> - - # TODO: Ultimately this should be TestSkipped
> - - # or PlatformDeficiency
> - - return
> + raise TestSkipped('OS does not support mkfifo')
>
> ^- I think we want a comment that this should be an 'UnavailableFeature'
OK, it's doable. Will do.
>
> + raise TestSkipped('pycurl do not check HTTP_PROXY '
> + 'for security reasons')
>
> ^- This should be: pycurl does not ...
>
> (including in the nearby comment.)
I'm copy-pasting from the comment above, so it's not my fault.
>
>
> The rest looks good.
>
> John
> =:->
More information about the bazaar
mailing list